search

sdkman / sdkman-db-migrations

Database migrations for the sdkman API
Apache License 2.0
69 stars 123 forks source link

Add Spark 3.5.1 and older patches #696

Closed cphbrt closed 3 weeks ago

cphbrt commented 1 month ago

Hi! I've made similar contributions to this repo in https://github.com/sdkman/sdkman-db-migrations/pull/672 and https://github.com/sdkman/sdkman-db-migrations/pull/614.

The primary goal of this PR is to add Spark 3.5.1. I added the other missing patch versions back to 2.0.2, the oldest available in sdkman. Let me know if that was too ambitious, and I can remove those and leave 3.5.1.

Updates:

marc0der commented 1 month ago

Hi @cphbrt , you could collapse all of them into a single changeset like you will see elsewhere in the code. You can also remove the old change sets that have become obsolete. We're trying to stop this project from expanding as much as possible to keep the build time down.

cphbrt commented 4 weeks ago

👍 Agreed. I didn't think about the accruing changesets. Updated accordingly. Thanks!

marc0der commented 3 weeks ago

Hey @cphbrt , I'v pushed some changes on my local branch for future reference. If you're happy with that, I can merge it: https://github.com/sdkman/sdkman-db-migrations/pull/698/files

marc0der commented 3 weeks ago

I merged my branch (which has your commit in), but GH isn't smart enough to pick that up. Closing this PR, but rest assured, your changes are in there :muscle:

Thanks for contributing. It's a great help!

cphbrt commented 3 weeks ago

@marc0der Elegant approach to handling the version and distribution variation. Thank you for working through it with me. Cheers!

marc0der commented 3 weeks ago

My pleasure, and thanks again for your help!