sdkman / sdkman-disco-integration

10 stars 11 forks source link

Missing SapMachine & Zulu Java releases #1

Closed norrisjeremy closed 2 years ago

norrisjeremy commented 2 years ago

The following Java releases appear to be missing even though they have been out for awhile:

  1. SapMachine 17.0.3.0.1
  2. SapMachine 11.0.15.0.1
  3. Zulu 18.0.1

When will these be made available for installation by SDKMAN?

eddumelendez commented 2 years ago

Thanks for reporting the issue. Zulu is fixed via https://github.com/sdkman/sdkman-disco-migration/commit/d057791ba0fb2dd3be9a78da612bffbfbe2feab9 and I will take a look at sapmachine later today.

eddumelendez commented 2 years ago

I have identified the issue and currently disco API is returning:

{
  "result": [
    {
      "id": "e027e226e323d1d6a0fd0300857f018c",
      "archive_type": "tar.gz",
      "distribution": "sap_machine",
      "major_version": 11,
      "java_version": "11.0.15",
      "distribution_version": "11.0.15",
      "jdk_version": 11,
      "latest_build_available": true,
      "release_status": "ga",
      "term_of_support": "lts",
      "operating_system": "linux",
      "lib_c_type": "glibc",
      "architecture": "x64",
      "fpu": "unknown",
      "package_type": "jdk",
      "javafx_bundled": false,
      "directly_downloadable": true,
      "filename": "sapmachine-jdk-11.0.15.0.1_linux-x64_bin.tar.gz",
      "links": {
        "pkg_info_uri": "https://api.foojay.io/disco/v3.0/ids/e027e226e323d1d6a0fd0300857f018c",
        "pkg_download_redirect": "https://api.foojay.io/disco/v3.0/ids/e027e226e323d1d6a0fd0300857f018c/redirect"
      },
      "free_use_in_production": true,
      "tck_tested": "unknown",
      "tck_cert_uri": "",
      "aqavit_certified": "unknown",
      "aqavit_cert_uri": "",
      "size": 192957167,
      "feature": []
    },
    {
      "id": "740e20b10179d4ff4730de1823d8abe8",
      "archive_type": "tar.gz",
      "distribution": "sap_machine",
      "major_version": 11,
      "java_version": "11.0.15",
      "distribution_version": "11.0.15",
      "jdk_version": 11,
      "latest_build_available": true,
      "release_status": "ga",
      "term_of_support": "lts",
      "operating_system": "linux",
      "lib_c_type": "glibc",
      "architecture": "x64",
      "fpu": "unknown",
      "package_type": "jdk",
      "javafx_bundled": false,
      "directly_downloadable": true,
      "filename": "sapmachine-jdk-11.0.15_linux-x64_bin.tar.gz",
      "links": {
        "pkg_info_uri": "https://api.foojay.io/disco/v3.0/ids/740e20b10179d4ff4730de1823d8abe8",
        "pkg_download_redirect": "https://api.foojay.io/disco/v3.0/ids/740e20b10179d4ff4730de1823d8abe8/redirect"
      },
      "free_use_in_production": true,
      "tck_tested": "unknown",
      "tck_cert_uri": "",
      "aqavit_certified": "unknown",
      "aqavit_cert_uri": "",
      "size": 192965799,
      "feature": []
    }
  ],
  "message": "2 package(s) found"
}

We are currently using the java_version in order to look for if the version exist in sdkman and 11.0.15 already does. Talking with the team in order to see where 11.0.15.0.1 and 17.0.3.0.1 should go.

norrisjeremy commented 2 years ago

FYI, the original 11.0.15 and 17.0.3 releases are also missing for SapMachine.

eddumelendez commented 2 years ago

I just realized this 17.0.3.0.1-sapmchn exceeds length. Current 18 and 11.0.15.0.1-sapmchn exceeds length. Current 19. @marc0der should we increase it?

norrisjeremy commented 2 years ago

Any updates on this?

Also, SAP has released a followup 18.0.1.1 version that is also missing.

eddumelendez commented 2 years ago

18.0.1.1 is in sdk already the other version will not until we remove the length constraint which should be when @marc0der is back from holidays.

norrisjeremy commented 2 years ago

18.0.1.1 is in sdk already the other version will not until we remove the length constraint which should be when @marc0der is back from holidays.

Why are the original 11.0.15 and 17.0.3 releases missing though, since they don't violate the length constraint?

norrisjeremy commented 2 years ago

Any updates on this? It's been a month and the most recent 11.x & 17.x releases from SAP are still not being offered for installation by SDKMAN.

eddumelendez commented 2 years ago

@norrisjeremy sorry about the delay. 11.0.15-sapmchn and 17.0.3-sapmchn are just available. Usually mac binaries take some time to become available and I think in this case it crossed paths with 11.0.15.0.1 and 17.0.3.0.1 which didn't meet the validations. So, since the app is taking the last version it has been always trying to submit those.

We are going to remove the validation in order to allow those releases, you can subscribe to this pr.

eddumelendez commented 2 years ago

11.0.15.0.1-sapmchn and 17.0.3.0.1-sapmchn are available now