search

sdkman / sdkman-disco-integration

10 stars 11 forks source link

Update the vendor of dragonwell #16

Open Accelerator1996 opened 10 months ago

Accelerator1996 commented 10 months ago

@eddumelendez Please review the PR, thank you very much!

eddumelendez commented 10 months ago

Hi, this should match the one in sdkman. I haven't seen any in sdkman about it. Can you point me to that change?

Accelerator1996 commented 9 months ago

Hi, this should match the one in sdkman. I haven't seen any in sdkman about it. Can you point me to that change?

Hi, our company's name is Alibaba, and our jdk is called Alibaba Dragonwell. The original albba is not clear enough, so I want to update the vendor.

eddumelendez commented 9 months ago

the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename?

Accelerator1996 commented 9 months ago

the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename?

Sorry, please tell me which repo should I make changes in?

tonycody commented 9 months ago

the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename?

Sorry, please tell me which repo should I make changes in?

@Accelerator1996 理论上这个直接合并就行了，因为 Dragonwell 在 Foojay Disco 里面没有变化。

https://github.com/sdkman/sdkman-candidates https://github.com/sdkman/sdkman-website

里面都得变更，否则映射不上！

@eddumelendez He's just trying to change the vendor mapping. The albba names didn't make sense in the past.