search

sdkman / sdkman-disco-integration

10 stars 11 forks source link

Add JetBrains EA #19

Closed njimenezotto closed 3 months ago

njimenezotto commented 4 months ago

Adding JDK 21 from JetBrains that has status EA

StefanLobbenmeierObjego commented 3 months ago

I think getting the EA is no longer required, we can just get java 21 instead in the normal updater.

I checked the output at https://github.com/sdkman/sdkman-disco-integration/blob/5c27bfae3d5aad311db3922fb269013a4ccf6c4d/src/main/java/io/sdkman/automigration/controllers/JavaMigration.java#L54

GA is this one: PackageResponse[distribution=jetbrains, architecture=x64, javaVersion=21.0.3+4532, jdkVersion=21, operatingSystem=linux, filename=jbrsdk_jcef-21.0.3-linux-x64-b453.2.tar.gz, releaseStatus=ga, javafxBundled=false, links=Links[pkgInfoUri=https://api.foojay.io/disco/v3.0/ids/9349c3d3790183a4ae050bf78834158d], feature=[]]

And there are 2 EA builds returned:

eddumelendez commented 3 months ago

Adding EA to every vendor will increase the maintainance of those versions. We are just doing so for OpenJDK and GraalVM

StefanLobbenmeierObjego commented 3 months ago

Not sure if there is a good way to do this otherwise, but I can find 2 pre releases of JBR 21: Release 21b75.2 Release 21b126.4

It looks like those 2 are the ones returned by the ea (from eyeballing the version numbers)

The first "proper" release is this one: Release 21b212.1

And the latest one is this one (from 1h ago): Release 21.0.3b458.1

Foojay still returns the one from last week: Release 21.0.3b453.2

But I am assuming they will switch to the one from 1h soon.

I was going to link my PR but looks like the maintainer was faster to merge it 😄 https://github.com/sdkman/sdkman-disco-integration/pull/20