search

sdl60660 / river-runner

Uses USGS/MERIT Basin data to visualize the path of a rain droplet to its endpoint.
https://river-runner-global.samlearner.com/
GNU General Public License v3.0
383 stars 26 forks source link

Hebrew is backwards #25

Closed diericx closed 2 years ago

diericx commented 2 years ago

Might not be an issue on your end at all, but I noticed Israel appears like this: לארשי But it should be: ׳שראל

All Hebrew is reading left to right instead of right to left. I cannot confirm the issue affects other RTL languages, but I would assume so.

sdl60660 commented 2 years ago

Ah, interesting. Were you seeing that in the navigation box in the top-right corner, or on the map? Or was this on mobile?

diericx commented 2 years ago

Desktop, on the map Confirmed issue is on both Firefox 95.0.2 and Safari 15.1 on MacOS 12.0.1

sdl60660 commented 2 years ago

Should be resolved now, on this commit: https://github.com/sdl60660/river-runner/commit/08e2f85a15c78efc638c032674cb766b9f1764fe

Thank you!