Extend lifetimes in subtrie

sdleffler / qp-trie-rs

An idiomatic and fast QP-trie implementation in pure Rust.

Mozilla Public License 2.0

94 stars 24 forks source link

Closed s3bk closed 2 years ago

s3bk commented 3 years ago

There is no need to limit the lifetime of the output to that of the subtrie borrow.

sdleffler commented 3 years ago

I'm happy to extend the output lifetime, but is there a particular reason for modify_or_insert? The Entry API exists for that kind of use case.

s3bk commented 3 years ago

Sorry, no. Just my incapability of working with git.

s3bk commented 3 years ago

@sdleffler unrolled the other stuff, which may or may not end up in a second PR later.

sdleffler commented 2 years ago

Oops. TIL that force pushing after a rebase will make github angry. Either way, merging this into main now!