search

sdleffler / qp-trie-rs

An idiomatic and fast QP-trie implementation in pure Rust.
Mozilla Public License 2.0
95 stars 24 forks source link

Fixes #31 #32

Closed erikbrinkman closed 1 year ago

erikbrinkman commented 1 year ago

This PR fixes issue #31 by explicitly passing a mutable reference to the count into entry creation. It's not the most elegant, but it works well enough and should only adds small amount to the memory footprint of entry manipulation.

This PR also includes a change that adds clippy lints to the tests, and fixes the existing "problems". It's only included because github makes stacked PRs from outside the repository pretty difficult. The clippy changes are pretty simple, but if you really don't want this included, I can strip it out.

sdleffler commented 1 year ago

Thank you for your work!

kevinaboos commented 1 year ago

Awesome, thanks so much for tackling this!