search

sdlins / yii2-at-least-validator

Makes one or more attributes mandatory inside a set of attributes.
Apache License 2.0
28 stars 19 forks source link

New param Max #12

Closed Maykonn closed 6 years ago

Maykonn commented 7 years ago

Max param will set the maximum quantity of chosen attributes must to be filled. If you have 3 attributes but just 1 must to be filled then set max=1. Default value for max is 0(all attributes can be filled).

Maykonn commented 7 years ago

Resolving #11

Maykonn commented 7 years ago

Hello!

Someone can merge this pull request on master?

sdlins commented 7 years ago

Sorry, I have been very busy studying other things last months... I will review your PR and merge if it is ok. Thank you so much for your contribuition.

sdlins commented 7 years ago

@Maykonn, thank you for your work. I will wait you fix the minor details appointed here and resend the PR.

sdlins commented 6 years ago

It will be closed till it is ok. Thank you for your contribution!

Maykonn commented 6 years ago

@slinstj The pull-request was accepted?

sdlins commented 6 years ago

@Maykonn, it was not accepted for now. Please, read the messages I attached into the code. Thank you.

Maykonn commented 6 years ago

I don't understand. See https://github.com/slinstj/yii2-at-least-validator/pull/12/commits/b418475e99cd5ffbf35745e3020a2904523369f6

sdlins commented 6 years ago

I have seen. Please, see my comments in your PR. Thank you again dude!