sdmp / sdmp.github.io

The main front-page and docs for the sdmp project.
https://sdmp.io
2 stars 2 forks source link

"view on Github" banner is a bit misleading #44

Open TehShrike opened 8 years ago

TehShrike commented 8 years ago

The "view on Github" diagonal text in a serif font evokes the "edit this post" link of Noddity, but is functionally different (it doesn't open the current post to be edited, it just takes you to the repo's readme)

Github's banner is well-understood to take you to the repo's home page, though it's not as trendy to use as it used to be. Maybe consider Github Corners as an alternative?

saibotsivad commented 8 years ago

Yeah, that's a good point. The "view on Github" was actually copied from Noddity's "edit this post" style, and it doesn't mean anything particular since it doesn't link to the page it's on.

I'm torn between removing it entirely, and changing it so it links to the correct markdown file...

TehShrike commented 8 years ago

I actually like the idea of a global "take me to the Github project" icon for projects like this. I would just prefer it evoke the Github banners more than Noddity's post-editing link.