search

sdmx-twg / vtl

This repository is used for maintaining the SDMX-VTL specification
11 stars 7 forks source link

Review time_agg operator #512

Open antonio-olleros opened 2 months ago

antonio-olleros commented 2 months ago

Issue Description

The time_agg operator has several definition issues that would be worth discussing. A first list here:

  1. periodIndFrom parameter: Looks like it is not necessary. The period in from is taken from the input time or time_period. On top, examples 2 to 4 are written without the second parameter,
  2. The operator should apply only to time_period types. With dates, we would need to do an implicit casting, which is not possible. For time, they don't have a period, so they should be casted to time_period, and it is not possible.
  3. We should separate the cases for aggregation and the cases for datasets without aggregation. Execution inside an aggregate operator is actually at component level, not dataset level. In fact, the manual says that at dataset level, the execution applies to a measure, while when applied for aggregation, it applies to the identifier. I think this point should be clarified in the manual.

Proposed Solution

Review the definition of the operator