sdmx3mdt / public-consultation

0 stars 0 forks source link

Remove "sentinelValues" boolean (not required property) #6

Closed dosse closed 3 years ago

dosse commented 3 years ago

It should be sufficient to have the optional "Sentinel" value array, which should be called "SentinelValues". Indeed, since it's optional, if there is no value array, it means that there are no sentinel values. An additional boolean seems superfluous.

sdmx3mdt commented 3 years ago

@dosse does this relate to the XML schemas, the information model, or both? Grateful if you could clarify.

dosse commented 3 years ago

@sdmx3mdt This is related to the schemas.

Also the IM (page 86) is not very clear on this:

Class Feature Description
SentinelValuesType A facet that indicates whether an Attribute or a Measure has sentinel values with special meaning, within their data type.
SentinelValue A value that has a special meaning within the representation of its Component
+name An association of a Sentinel Value to a multilingual name.
+description An association of a Sentinel Value to a multilingual description.

'SentinelValuesType" seems not only superfluous but even miss-leading, because it's not about a type. I guess this is why is was renamed in the schemas.

It should really be sufficient to just list sentinel values, if there are any. I don't see a need to add another boolean. The simpler, the better.

sdmx3mdt commented 3 years ago

TF2 to clarify Section 2 information model specification on Sentinel Values

sdmx3mdt commented 3 years ago

Schemas fixed in release candidate working branch https://github.com/sdmx3mdt/sdmx-ml/tree/develop.

Outstanding action with TF2 to update the IM and Section 2.

sdmx3mdt commented 3 years ago

27 July 2021 Change approved by the SDMX TWG. Details are set out in the attached document: SDMX TWG TF2 - public review issues.docx

Outstanding actions:

sdmx3mdt commented 3 years ago

SDMX-ML schemas: sentinelValues boolean removed

Section 2: sentinelValues boolean removed