search

sdnfv / onvm-snort

Snort IDS ported to OpenNetVM
17 stars 13 forks source link

Update to ONVM 19.07 #8

Closed archit-p closed 4 years ago

archit-p commented 5 years ago

This pull request updates the onvm-snort repository to run with onvm 19.07.

Changes were made in libdaq code and configure scripts. A gitignore file was added to ensure clean commits.

archit-p commented 5 years ago

Oops looks like I forgot to update the openNetVM version in the repository. Would it be better to use a openNetVM as a submodule here?

twood02 commented 5 years ago

Yes, using a submodule would be ideal. Let us know when it is ready for us to take a look again. Thanks @archit-p !

archit-p commented 5 years ago

Hi,

I've updated the repository to include openNetVM 19.07 as a submodule. Have also updated the installation instructions in install.md, and installation script in install.sh. I'd really appreciate it if someone could follow these instructions and try a fresh installation!

archit-p commented 5 years ago

Hello team,

Just a gentle reminder on the open pull request. Please provide suggestions on how to take this forward.

twood02 commented 5 years ago

Thanks @archit-p . @dennisafa is going to take a look but he may not get to it for another week because of class work.

archit-p commented 5 years ago

@dennisafa is the current code building alright?

dennisafa commented 5 years ago

Hi Archit, i’ve run into a few issues compiling the code. I’ll get to it this Thursday - i have a few deadlines before then.

On Tue, Oct 22, 2019 at 12:35 PM Archit Pandey notifications@github.com wrote:

@dennisafa https://github.com/dennisafa is the current code building alright?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sdnfv/onvm-snort/pull/8?email_source=notifications&email_token=AH3EIZUMNB3OYYI32PDN2NLQP4TUXA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6MN4I#issuecomment-545048305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3EIZWAO4AGJWFQ77BMZ7LQP4TUXANCNFSM4I76KWHA .

archit-p commented 5 years ago

Hi dennis,

No problems, you could share the issues here

archit-p commented 5 years ago

That's strange, I didn't need to update my $PATH. Could you share the snort config.log file? It might contain what the error is exactly.

On Fri, 25 Oct 2019, 8:37 am Dennis Afanasev, notifications@github.com wrote:

@dennisafa commented on this pull request.

In Install.md https://github.com/sdnfv/onvm-snort/pull/8#discussion_r338869726:

 ```sh
  • ./configure --enable-sourcefire
  • aclocal
  • autoconf
  • autoheader
  • automake -a
  • 
+3. Run the configuration script.

I think the issue is that the $PATH variable needs to be initialized to point to the daq-modules-config file. This file is found in /daq-2.0.6/os-daq-modules

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sdnfv/onvm-snort/pull/8?email_source=notifications&email_token=AHMM4LEO5PPRTH5LVSR32NLQQJPINA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJF6B4I#discussion_r338869726, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LE5ACXAWGBTY3XAC3LQQJPINANCNFSM4I76KWHA .

dennisafa commented 5 years ago

That's strange, I didn't need to update my $PATH. Could you share the snort config.log file? It might contain what the error is exactly. … On Fri, 25 Oct 2019, 8:37 am Dennis Afanasev, @.> wrote: @*.** commented on this pull request. ------------------------------ In Install.md <#8 (comment)>: > sh - ./configure --enable-sourcefire + aclocal + autoconf + autoheader + automake -a + +3. Run the configuration script. I think the issue is that the $PATH variable needs to be initialized to point to the daq-modules-config file. This file is found in /daq-2.0.6/os-daq-modules — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AHMM4LEO5PPRTH5LVSR32NLQQJPINA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJF6B4I#discussion_r338869726>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LE5ACXAWGBTY3XAC3LQQJPINANCNFSM4I76KWHA .

Screen Shot 2019-10-24 at 11 21 13 PM

Here is the relevant config.log section. Looks like there are issue with -lonvm and -lonvmhelper

archit-p commented 5 years ago

Looks like $DPDK_TARGET is not being interpreted correctly.

Could you try echo $DPDK_TARGET and if nothing pops up, export $DPDK_TARGET=x86_64-native-linuxapp-gcc or your corresponding architecture.

On a side note, I believe I should remove the use of $DPDK_TARGET and stick to $RTE_TARGET in daq-2.0.6/configure.ac. WDYT?

On Fri, 25 Oct 2019, 8:52 am Dennis Afanasev, notifications@github.com wrote:

That's strange, I didn't need to update my $PATH. Could you share the snort config.log file? It might contain what the error is exactly. … <#m306845524257962216> On Fri, 25 Oct 2019, 8:37 am Dennis Afanasev, @.*> wrote: @.** commented on this pull request. ------------------------------ In Install.md <#8 (comment) https://github.com/sdnfv/onvm-snort/pull/8#discussion_r338869726>: > sh

  • ./configure --enable-sourcefire + aclocal + autoconf + autoheader + automake -a + +3. Run the configuration script. I think the issue is that the $PATH variable needs to be initialized to point to the daq-modules-config file. This file is found in /daq-2.0.6/os-daq-modules — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 https://github.com/sdnfv/onvm-snort/pull/8?email_source=notifications&email_token=AHMM4LEO5PPRTH5LVSR32NLQQJPINA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJF6B4I#discussion_r338869726>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LE5ACXAWGBTY3XAC3LQQJPINANCNFSM4I76KWHA .

[image: Screen Shot 2019-10-24 at 11 21 13 PM] https://user-images.githubusercontent.com/32916582/67540859-01ba2280-f6b5-11e9-992d-2af22fd63aba.png Here is the relevant config.log section. Looks like there are issue with -lonvm and -lonvmhelper

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sdnfv/onvm-snort/pull/8?email_source=notifications&email_token=AHMM4LDHD6AWV3HYZOG34JLQQJQ53A5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHB2HQ#issuecomment-546184478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LDBWT62T5AI2VI5BKDQQJQ53ANCNFSM4I76KWHA .

dennisafa commented 5 years ago

Looks like $DPDK_TARGET is not being interpreted correctly. Could you try echo $DPDK_TARGET and if nothing pops up, export $DPDK_TARGET=x86_64-native-linuxapp-gcc or your corresponding architecture. On a side note, I believe I should remove the use of $DPDK_TARGET and stick to $RTE_TARGET in daq-2.0.6/configure.ac. WDYT? On Fri, 25 Oct 2019, 8:52 am Dennis Afanasev, notifications@github.com wrote: … That's strange, I didn't need to update my $PATH. Could you share the snort config.log file? It might contain what the error is exactly. … <#m306845524257962216> On Fri, 25 Oct 2019, 8:37 am Dennis Afanasev, @.*> wrote: @.** commented on this pull request. ------------------------------ In Install.md <#8 (comment) <#8 (comment)>>: > sh - ./configure --enable-sourcefire + aclocal + autoconf + autoheader + automake -a + +3. Run the configuration script. I think the issue is that the $PATH variable needs to be initialized to point to the daq-modules-config file. This file is found in /daq-2.0.6/os-daq-modules — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 <#8>?email_source=notifications&email_token=AHMM4LEO5PPRTH5LVSR32NLQQJPINA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJF6B4I#discussion_r338869726>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LE5ACXAWGBTY3XAC3LQQJPINANCNFSM4I76KWHA . [image: Screen Shot 2019-10-24 at 11 21 13 PM] https://user-images.githubusercontent.com/32916582/67540859-01ba2280-f6b5-11e9-992d-2af22fd63aba.png Here is the relevant config.log section. Looks like there are issue with -lonvm and -lonvmhelper — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AHMM4LDHD6AWV3HYZOG34JLQQJQ53A5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHB2HQ#issuecomment-546184478>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LDBWT62T5AI2VI5BKDQQJQ53ANCNFSM4I76KWHA .

Yes, let's stick with using $RTE_TARGET as that is part of the openNetVM install guide. Thank you.

archit-p commented 5 years ago

Sure, will do that!

I remember the old guide using two variables RTE_TARGET and DPDK_TARGET with the same value.

archit-p commented 5 years ago

There are extra print statements in several places. I believe, they were used when debugging daq_netvm.c.

archit-p commented 5 years ago

There are too many commits in my repository right now, I wish to squash or fixup most of them.

Could you let me know once you approve of the changes? I'll make a force push with modified history.

archit-p commented 5 years ago

-ldpdk is found in $RTE_SDK/$RTE_TARGET/lib

From the screenshot it looks to me like your $RTE_SDK variable is still set to the dpdk-16.11 directory. You might need to set it again.

On Fri, 25 Oct 2019, 9:28 am Dennis Afanasev, notifications@github.com wrote:

@dennisafa commented on this pull request.

In Install.md https://github.com/sdnfv/onvm-snort/pull/8#discussion_r338877707:

```sh

cd ../ ./patching-Makefile.sh

-4. Navigate to the src folder of snort and Make snort. +5. Navigate to the src folder of snort and Make snort.

Please add a step asking the user to run autoreconf -ivf in case of a version mismatch error, then to do step 3 again. Also, I am getting this issue: [image: Screen Shot 2019-10-24 at 11 57 43 PM] https://user-images.githubusercontent.com/32916582/67542278-2369d880-f6ba-11e9-80b7-dcceb6cb1cf6.png

Could you elaborate on -ldpdk a bit more?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sdnfv/onvm-snort/pull/8?email_source=notifications&email_token=AHMM4LFSHMT2VGLOO7RECDLQQJVHTA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJGANEA#pullrequestreview-306972304, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LGLPKGSNW5DDL46A6DQQJVHTANCNFSM4I76KWHA .

dennisafa commented 5 years ago

-ldpdk is found in $RTE_SDK/$RTE_TARGET/lib From the screenshot it looks to me like your $RTE_SDK variable is still set to the dpdk-16.11 directory. You might need to set it again. … On Fri, 25 Oct 2019, 9:28 am Dennis Afanasev, @.> wrote: @*.** commented on this pull request. ------------------------------ In Install.md <#8 (comment)>: > sh cd ../ ./patching-Makefile.sh -4. Navigate to the src folder of snort and Make snort. +5. Navigate to the src folder of snort and Make snort. Please add a step asking the user to run autoreconf -ivf in case of a version mismatch error, then to do step 3 again. Also, I am getting this issue: [image: Screen Shot 2019-10-24 at 11 57 43 PM] https://user-images.githubusercontent.com/32916582/67542278-2369d880-f6ba-11e9-80b7-dcceb6cb1cf6.png Could you elaborate on -ldpdk a bit more? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AHMM4LFSHMT2VGLOO7RECDLQQJVHTA5CNFSM4I76KWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJGANEA#pullrequestreview-306972304>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMM4LGLPKGSNW5DDL46A6DQQJVHTANCNFSM4I76KWHA .

It looks like my $RTE_SDK output is correct (set to onvm-snort/openNetVM/dpdk) I will look into it.

archit-p commented 5 years ago

Might be helpful to try running 

sudo ldconfig

once DAQ is done installing.

archit-p commented 5 years ago

Hi, any updates on the build status?

You could try running:

aclocal
autoconf 
automake -a
autoheader
./configure --enable-sourcefire --enable-static --disabled-shared

and skipping the patching step. I'm unsure of whether the patching step is needed.

dennisafa commented 5 years ago

Hi, any updates on the build status?

You could try running:

aclocal
autoconf 
automake -a
autoheader
./configure --enable-sourcefire --enable-static --disabled-shared

and skipping the patching step. I'm unsure of whether the patching step is needed.

I will try this today - thanks for the communication.

archit-p commented 5 years ago

Hello,

I've run a clean build multiple times locally, would appreciate if someone with a different setup could verify the build.

We could use some more eyes to the pull request @twood02 @ratnadeepb!

archit-p commented 5 years ago

In order to fix this error, please pull the latest changes, and repeat Step 5 Configure and run openNetVM-snort in install.md.

dennisafa commented 5 years ago

In order to fix this error, please pull the latest changes, and repeat Step 5 Configure and run openNetVM-snort in install.md.

Thanks archit, I'll run a fresh build today.

dennisafa commented 5 years ago

I managed to get a working build running with a few modifications to the install guide (see comments above) After you change those, I'll approve the PR. Thank you!

archit-p commented 5 years ago

Hi @dennisafa

Thanks a lot for reviewing the changes. I've updated the pull request according to your suggestions above.

archit-p commented 5 years ago

@dennisafa I've merged commits into a more manageable number. You could merge these if the changes are approved. Thanks.

archit-p commented 4 years ago

Hi, does this merge request require anymore changes?

dennisafa commented 4 years ago

Hi, does this merge request require anymore changes?

Hi Archit, I ran into a few issues when re-building on a fresh instance. I've had a lot of work pile up so I haven't gotten around to figuring out the exact issue quite yet. I will retry and submit a change to the install guide by this weekend. Thanks for your patience!

dennisafa commented 4 years ago

Hey @archit-p let me know if you have any questions about the comments!

archit-p commented 4 years ago

Hi, apologies for being away for so long. I have made the requested changes and updated the pull request! Thanks for reviewing!

archit-p commented 4 years ago

Hi @twood02! Could you look at the proposed changes?

twood02 commented 4 years ago

Thanks @archit-p! I'll be discussing this with Dennis tomorrow and expect to merge it after that. We already have other students who are interested in using your code so your contribution is greatly appreciated!