Closed koolzz closed 5 years ago
In response to PR creation
Your results will arrive shortly
In response to PR creation
Run successful see results: [Results from nimbnode30] Median TX pps for Speed Tester: 35126957
examples/aes_decrypt/aes.h:176: #endif line should be "#endif // _AESH" [build/header_guard] [5]
Total errors found: 1
examples/aes_encrypt/aes.h:185: #endif line should be "#endif // _AESH" [build/header_guard] [5]
Total errors found: 1
examples/flow_table/flow_table.h:63: #endif line should be "#endif // _FLOW_TABLEH" [build/header_guard] [5]
Total errors found: 1
examples/flow_table/msgbuf.h:71: #endif line should be "#endif // _MSGBUFH" [build/header_guard] [5]
Total errors found: 1
examples/flow_table/openflow.h:969: #endif line should be "#endif // _OPENFLOWH" [build/header_guard] [5]
examples/flow_table/openflow.h:50: Using deprecated casting style. Use static_cast
@kevindweb you have used this for webstuff so give it a review
Just in case @onvm
Just in case @onvm
Your results will arrive shortly
Just in case @onvm
Run successful see results: [Results from nimbnode30] Median TX pps for Speed Tester: 35135240
examples/aes_decrypt/aes.h:176: #endif line should be "#endif // _AESH" [build/header_guard] [5]
Total errors found: 1
examples/aes_encrypt/aes.h:185: #endif line should be "#endif // _AESH" [build/header_guard] [5]
Total errors found: 1
examples/flow_table/flow_table.h:63: #endif line should be "#endif // _FLOW_TABLEH" [build/header_guard] [5]
Total errors found: 1
examples/flow_table/msgbuf.h:71: #endif line should be "#endif // _MSGBUFH" [build/header_guard] [5]
Total errors found: 1
examples/flow_table/openflow.h:969: #endif line should be "#endif // _OPENFLOWH" [build/header_guard] [5]
examples/flow_table/openflow.h:50: Using deprecated casting style. Use static_cast
Fix NF Tag to properly display it in stats later
Summary:
Before we were passing a
const char *
for the nf tag and the pointer was local NF stack memory, which was clearly not accessible by the onvm_mgr. This pr fixes this issue by placing nf_tag on the heap and defining a max length of the provided nf tag.This has no breaking changes as its all internal logic.
With this PR we have everything to rework stdout stats with both a tag and the core info(lets discuss formatting details in the meeting). Also, @kevindweb you gotta handle webstats, every NF can now be properly labeled (Speed Tester 1) instead of (NF 1) 😉
Usage: Tested by printing
%s
with tag from the onvm_mgr stats output.Merging notes:
TODO before merging :
Test Plan:
Test functionality, makes sure onvm no break
Review:
TBA