Closed dennisafa closed 5 years ago
In response to PR creation
Your results will arrive shortly
In response to PR creation
Run successful see results: [Results from nimbnode30] Median TX pps for Speed Tester: 35184761
examples/arp_response/arp_response.c:284: Lines should be <= 120 characters long [whitespace/line_length] [5]
Total errors found: 1
examples/flow_table/openflow.h:50: Using deprecated casting style. Use static_cast
@onvm I need a pr with linter conflicts
@onvm I need a pr with linter conflicts
Your results will arrive shortly
@onvm I need a pr with linter conflicts
Error: ERROR: Script failed on nimbnode30
@onvm should be good to go
@onvm should be good to go
Your results will arrive shortly
@onvm jk, but now for sure
@onvm jk, but now for sure
Your results will arrive shortly
@onvm is the linter pleased
@onvm is the linter pleased
Your results will arrive shortly
@onvm how's your weekend been?
@onvm how's your weekend been?
Another CI run in progress, please try again in 15 minutes
When running the advanced rings mode in speed tester and scaling, closing the manager would not kill the NF running. (referencing #105 )
Summary:
This adds a message handler in the advanced rings loop that listens for the MSG_STOP macro sent by the manager.
Usage:
Merging notes:
TODO before merging :
Test Plan:
Run the manager, then run speed tester (or scaling) with advanced ring mode:
./go.sh 1 -d 1 -a
Close the manager, assure that the NF is stopping.Review:
@koolzz @kevindweb I was thinking for sanity checks maybe try running several of the same NF and speed tester + scaling then closing manager.
Sanity checks, assigned to @koolzz @kevindweb
Code style, assigned to @koolzz @kevindweb
Code design, assigned to @koolzz @kevindweb
Documentation, assigned to @koolzz @kevindweb
(optional) Subscribers: << @-mention people who probably care about these changes >>