Closed kevindweb closed 5 years ago
In response to PR creation
Your results will arrive shortly
@onvm do your thing π
@onvm do your thing π
Your results will arrive shortly
This one is next @onvm
This one is next @onvm
Your results will arrive shortly
From Issue 107, go script couldn't handle multi-word string arguments
Summary:
Specifically in the
payload_scan
NF, running with the required./go.sh 1 -d 1 -s "My String Here"
would not work with multiple words. While./go.sh 1 -d 1 -s computer
or "computer" works well, bash strips the quotes with variable assignment, so "computer here" would become computer here. Thus the cgetopt
would not recognize the wordhere
.Usage:
Merging notes:
TODO before merging :
Test Plan:
Run multiple NFs with tons of arguments to ensure the go script doesn't fail. Make sure to run with DPDK arguments as well, to check that errors are handled correctly still. Only adding DPDK without ONVM args should fail, from previous edits to go scripts.
Sanity checks, assigned to @koolzz @dennisafa
Run linter
Check for scripting errors
Performance, assigned to @koolzz @dennisafa