sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 136 forks source link

Launch script #114

Closed kevindweb closed 5 years ago

kevindweb commented 5 years ago

From Issue 107, go script couldn't handle multi-word string arguments

Summary:

Specifically in the payload_scan NF, running with the required ./go.sh 1 -d 1 -s "My String Here" would not work with multiple words. While ./go.sh 1 -d 1 -s computer or "computer" works well, bash strips the quotes with variable assignment, so "computer here" would become computer here. Thus the c getopt would not recognize the word here.

Usage:

This PR includes
Resolves issues Resolves #107
Breaking API changes
Internal API changes
Usability improvements
Bug fixes πŸ‘
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Run multiple NFs with tons of arguments to ensure the go script doesn't fail. Make sure to run with DPDK arguments as well, to check that errors are handled correctly still. Only adding DPDK without ONVM args should fail, from previous edits to go scripts.

onvm commented 5 years ago

In response to PR creation

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@onvm do your thing πŸ˜‰

onvm commented 5 years ago

@onvm do your thing πŸ˜‰

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

This one is next @onvm

onvm commented 5 years ago

This one is next @onvm

CI Message

Your results will arrive shortly