Refactors Advanced Rings API/Examples

koolzz commented 5 years ago

Currently the advanced ring support in onvm is not clean, this pr attempts to resolve this.

Summary:

This PR resolves such issues as:

Removing unused APIs
Removing support for APIs written for advanced rings (see advanced rings scaling) that would never actually be used by the developers, because if developers are using advanced rings the assumption is they will also want to manage their own threads etc.
Remove Advanced Rings mode from the Speed tester NF
Cleanup and redo adv ring mode in the Scaling NF, the mode now does its own pthread creation instead of relying on onvm scaling APIs. Also make a clear separation between default and advanced ring mode.
Because of the adv rings changes some internal nflib APIs were exposed to the NF (onvm_nflib_start_nf, onvm_nflib_init_nf_init_cfg, onvm_nflib_inherit_parent_init_cfg)

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes	👍
Usability improvements
Bug fixes
New functionality	👍
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

Dependencies: merge after #117

TODO before merging :

[ ] PR is ready for review

Test Plan:

Still working on it but primarily we will need to test the scaling NF

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

onvm commented 5 years ago

In response to PR creation

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@onvm go for it

onvm commented 5 years ago

@onvm go for it

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@onvm Nice how about this one

onvm commented 5 years ago

@onvm Nice how about this one

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@onvm linty lint

onvm commented 5 years ago

@onvm linty lint

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@onvm gogogo

onvm commented 5 years ago

@onvm gogogo

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@dennisafa @kevindweb Check this out if you have time, if shows a clean separation between adv and normal rings(at least it should so comment if this needs any changes).

@nks5295 This is good for review now. Updated the description

koolzz commented 5 years ago

@onvm comrade проверь код

onvm commented 5 years ago

@onvm comrade проверь код

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@onvm go for it

onvm commented 5 years ago

@onvm go for it

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

@nks5295 ready for your review 📝

sdnfv / openNetVM