search

sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 136 forks source link

Ci busy no more #143

Closed kevindweb closed 5 years ago

kevindweb commented 5 years ago

A huge improvement to testing pull requests throughout the day!

Summary:

Previously, CI would not run a request if another was already running. This is a bug annoyance (especially for @koolzz ) when trying to merge things and get the 'go ahead' from CI. Now, CI will send a message that if we are busy, it will run right after the last CI. This only happens if a duplicate request is not already there. For example, while CI is busy, we make a 2 requests in another PR, only one of them will be put in the list.

Usage: Regular with CI comment arguments

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality 👍
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Review:

@koolzz again please lmk if anything doesn't work

onvm commented 5 years ago

In response to PR creation

CI Message

Your results will arrive shortly

koolzz commented 5 years ago

Exiting stuff, will review soon!

kevindweb commented 5 years ago

@onvm test thread

kevindweb commented 5 years ago

@onvm test me again

kevindweb commented 5 years ago

@onvm testing again

onvm commented 5 years ago

@onvm testing again

CI Message

Your results will arrive shortly

kevindweb commented 5 years ago

@onvm authorized stick in queue

kevindweb commented 5 years ago

@onvm test please run

kevindweb commented 5 years ago

@onvm the lock is messed up

kevindweb commented 5 years ago

@onvm again

onvm commented 5 years ago

@onvm again

CI Message

Duplicate request already waiting, ignoring message

kevindweb commented 5 years ago

@onvm i believe in you

onvm commented 5 years ago

@onvm i believe in you

CI Message

Another CI run in progress, adding request to the end of the list

kevindweb commented 5 years ago

@onvm one last 2

onvm commented 5 years ago

@onvm one last 2

CI Message

Another CI run in progress, adding request to the end of the list

koolzz commented 5 years ago

@kevindweb fix the changes, I'll do a final review then

koolzz commented 5 years ago

Discussing these in slack

kevindweb commented 5 years ago

@onvm test

kevindweb commented 5 years ago

@onvm test

kevindweb commented 5 years ago

@onvm test 1

onvm commented 5 years ago

New message here

onvm commented 5 years ago

New message here

onvm commented 5 years ago

New message here

onvm commented 5 years ago

New message here

kevindweb commented 5 years ago

@onvm first one

onvm commented 5 years ago

@onvm first one

CI Message

Your results will arrive shortly

kevindweb commented 5 years ago

@onvm run me

kevindweb commented 5 years ago

@onvm test

kevindweb commented 5 years ago

onvmstats "commited" the changes because on nn44, cronjob for stats is running

onvm commented 5 years ago

qqq

CI Message

Error: ERROR: Failed to copy ONVM files to nimbnode17

kevindweb commented 5 years ago

I liked that idea, makes it look cleaner in add_request

koolzz commented 5 years ago

onvmstats is now sentient and pushing commits? I'm impressed with our development program. @onvm

onvm commented 5 years ago

qqq

CI Message

Error: ERROR: Failed to copy ONVM files to nimbnode17

onvm commented 5 years ago

qqq

CI Message

Error: ERROR: Failed to copy ONVM files to nimbnode17

onvm commented 5 years ago

qqq

CI Message

Error: ERROR: Failed to copy ONVM files to nimbnode17

koolzz commented 5 years ago

@onvm do your thing

onvm commented 5 years ago

@onvm do your thing

CI Message

Your results will arrive shortly