Macros for running flow table lookup

kevindweb commented 5 years ago

Referencing issue #62 , this pr adds a macro FLOW_LOOKUP to onvm_pkt.c to enable/disable our flow table lookup.

Summary:

Although this is a "good first issue", it's been an issue for a while, and @koolzz and I found it was very useful for testing the pktgen functionality in CI. Here's what I received with this added functionality. With ENABLE_FLOW_LOOKUP=1, from the max rx was 13331727, max tx was 14811688. Disabling the flow table lookup portion of onvm_pkt_process_rx_batch, we received max rx of 14783964, and max tx of 14785566. Over 1mil pps rx faster by disabling the flow table, which makes sense, but is good that we got it.

Usage: By default, per @twood02 's request in the original issue, flow lookups happen. But in /onvm/onvm_mgr/Makefile setting ENABLE_FLOW_LOOKUP=0, flow lookups will not happen. This is useful if only one port is running pktgen.

This PR includes
Resolves issues	#62
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality	👍
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

Dependencies: None
I want to merge this into the upcoming CI pktgen update, to leverage this functionality. We saw a 6mil pps increase by using this on the cluster nodes the other day. (no strict dependencies though)

TODO before merging :

[ ] PR is ready for review

Test Plan:

Make sure pktgen still works.

Review:

@koolzz you were there on Saturday talking about this @dennisafa I know you work a lot with Pktgen, if you could test this

kevindweb commented 5 years ago

I purposely turned off CI in testing, I will definitely run CI before merge.

koolzz commented 5 years ago

Won't merge before CI approves this though 😛

koolzz commented 5 years ago

Resolves issue #62 I think? Not 64

https://github.com/sdnfv/openNetVM/issues/62

kevindweb commented 5 years ago

@onvm will you be kind?