Closed kevindweb closed 4 years ago
@onvm can you run?
@onvm can you run?
Your results will arrive shortly
Merged all other dependencies, tested and packaged the web app. It all seems to be working.
@onvm show me what you got
@onvm show me what you got
Your results will arrive shortly
Testing PAT
Your results will arrive shortly
@onvm time to test the tokens
@onvm time to test the tokens
Your results will arrive shortly
@kevindweb this is good to merge right
I just merged the final web update. I verified it worked and didn't break. Minifying the updates made sure there weren't too many line changes.
Once we merge this @koolzz please go ahead and delete the pull requests from dependabot. I have merged all of their suggestions into this one so they will be useless.
@onvm can you review one last time
@onvm can you review one last time
Your results will arrive shortly
Onvm_web versioning updates from dependabot.
Summary:
I needed to manually build the new react app for onvm_web given the updated versions, which has to change a few of the
onvm_web/web-build
files. Luckily I made a minifying script last time that can build everything so it worked like a charm!Usage:
Merging notes:
TODO before merging :
Test Plan:
Ignore dependabot's pull request, because its commit is included here.
Review:
@koolzz or @dennisafa if you want to run it to test, if not that's fine because it doesn't touch any of the onvm code at all which is nice 👍