search

sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 136 forks source link

Ubuntu 18.04 & Tokens #176

Closed onvmstats closed 4 years ago

onvmstats commented 4 years ago

Ubuntu 18.04 is now where CI lives, and Personal Access Tokens are in use to be in accordance with Github's deprecation notice of user/pass hooks.

Summary:

Since moving the CI server to Ubuntu 18.04, there were a few changes necessary. We now use a specific CI user to run CI on the server instead of my account (which just makes more sense), so a new field worker_user was required for the scripted server to understand. For posterity reasons, the README was significantly updated so someone other than me will know how to move CI in the future to a new server if necessary. In some of the python scripts, we needed to run the paramiko logic in a separate function, which I called paramiko_run because there were issues with global variables being used. Finally, the only new script added was a python script using github3.py's token creation system. The configs have been updated to use the token, instead of just username and password. This was requested by Github as a deprecation notice. A final small change to run_ci.sh was adding a new install package required called pycryptodome. This was left out previously in the install guide, but is required to run correctly upon fresh install.

Usage: CI will run just as usual, it is more secure now with the tokens, though.

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality 👍
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Run CI on a few different PRs to ensure that it is working correctly. @nks5295 and I will keep in touch regarding the tokens, to ensure the permissions are secure and cannot be taken advantage of.

Review:

@koolzz @dennisafa @nks5295

onvm commented 4 years ago

In response to PR creation

CI Message

Your results will arrive shortly

koolzz commented 4 years ago

@kevindweb I'm a bit lost on the status of this one, lmk what the plan is

kevindweb commented 4 years ago

I already started moving CI over to the new repository. I think we just ignore this change. After CI is completely updated and on the other repo (and in a VM), I'll make a PR deleting CI from this repo. How does that sound? At that point I'll remove this PR so for now ignore this PR.

onvmstats commented 4 years ago

@onvm just run linter

onvm commented 4 years ago

@onvm just run linter

CI Message

Your results will arrive shortly

onvm commented 4 years ago

@onvm just run linter

CI Message

Error: ERROR: Failed to fetch and checkout pull request

onvmstats commented 4 years ago

@onvm testing

onvm commented 4 years ago

@onvm testing

CI Message

Your results will arrive shortly

onvmstats commented 4 years ago

@onvm testing with VM service

onvmstats commented 4 years ago

@onvm another test

onvmstats commented 4 years ago

@onvm test again

onvmstats commented 4 years ago

@onvm let's test linter

onvm commented 4 years ago

@onvm let's test linter

CI Message

Your results will arrive shortly

kevindweb commented 4 years ago

@onvm Run please

onvm commented 4 years ago

@onvm Run please

CI Message

Your results will arrive shortly

kevindweb commented 4 years ago

@onvm test with cleaned code

onvm commented 4 years ago

@onvm test with cleaned code

CI Message

Your results will arrive shortly

kevindweb commented 4 years ago

I will be making a new pull request for removing CI from onvm, goodbye old friend 🖖🏽, Vulcan salute to you!