sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
263 stars 136 forks source link

Manager and Examples check go scripts #180

Closed kevindweb closed 4 years ago

kevindweb commented 4 years ago

Our list of enhancements asks for checks to send a message and stop go scripts on certain fatal cases.

Summary:

ONVM go script should print a message and stop running if another manager is already running. Examples go script should print a message and exit if the manager is not running. The second case is not fatal, but the manager wouldn't be able to start up if an NF started before it. We just need to test that the manager can still run in the normal case and that NFs are not negatively affected.

Usage: Run ./go scripts in /onvm and /examples

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality 👍
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Test that starting up the manager or NF examples works as intended normally. Test that go script stops running in the previously mentioned cases.

Review:

@koolzz @dennisafa

onvm commented 4 years ago

In response to PR creation

CI Message

Your results will arrive shortly

onvm commented 4 years ago

In response to PR creation

CI Message

Error: Failed to parse Speed Tester stats

kevindweb commented 4 years ago

I'm fixing this, it's a PR error not CI

kevindweb commented 4 years ago

@onvm can you check this out

onvm commented 4 years ago

@onvm can you check this out

CI Message

Your results will arrive shortly