search

sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
261 stars 134 forks source link

Updated README.md with description of config file. #241

Closed khaledshahine closed 3 years ago

khaledshahine commented 4 years ago

<>

Summary:

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

onvm commented 4 years ago

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

kevindweb commented 4 years ago

@onvm approval?

kevindweb commented 4 years ago

@onvm awake?

onvm commented 4 years ago

@onvm awake?

CI Message

Your results will arrive shortly

onvm commented 4 years ago

@onvm awake?

CI Message

Error: Failed to copy ONVM files to nimbnode23

kevindweb commented 4 years ago

@this time

kevindweb commented 4 years ago

@onvm this time

onvm commented 4 years ago

@onvm this time

CI Message

Your results will arrive shortly

onvm commented 4 years ago

@onvm this time

CI Message

Error: Failed to copy ONVM files to nimbnode23

kevindweb commented 4 years ago

@onvm try again

twood02 commented 4 years ago

Thanks @khaledshahine for this documentation update!

@kevindweb - this PR is really only trying to modify one line of documentation: https://github.com/sdnfv/openNetVM/pull/241/commits/76fdd24d24adbefae74faee09eae460cdf37ec8e the other commits are because of repo differences I think. Can you figure out the git magic to clean this up so it only has the single relevant commit?

kevindweb commented 4 years ago

@tim the problem I think is he made the PR to master, so I think it's tracking that. The only thing I can think to do is for me (or @khaledshahine) to make a commit that merges develop's changes back into this branch git pull upstream/develop && git push, resetting all the "changes" so we should only see the one line change.

twood02 commented 3 years ago

@EthanBaron14 will try to clean up this branch so we can merge

EthanBaron14 commented 3 years ago

I looked into this, but unfortunately I don't have access to push onto someone else's branch. Since the docs/Install.md and the onvm/go.sh files weren't changed in this PR, I'd recommend just copy/pasting the contents of the versions of those files existing on the develop branch into this branch to fix the merge conflicts.

kevindweb commented 3 years ago

Pretty sure this should be closed from #258