sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
261 stars 134 forks source link

Improve usability of cloudlab profiles #263

Closed WilliamMaa closed 3 years ago

WilliamMaa commented 3 years ago

This PR relates to issue #262. I fixed some documentation issues, and improved general usability of onvm.

Summary:

  1. Now you can compile everything in the root directory instead of compiling dpdk, manager and examples separately.
  2. For cloudlab profiles, you only need to run setup_cloudlab.sh to setup all the environmental variables and do the environment setup. Usage:
This PR includes
Resolves issues #262
Breaking API changes
Internal API changes
Usability improvements X
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Try doing a make in a Ubuntu 20 environment under the root directory, see if it can correctly make everything. On cloudlab profiles, run setup_cloudlab.sh see if it correctly does the setup.

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

onvm commented 3 years ago

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

twood02 commented 3 years ago

These changes look good to me. @kevindweb or @dennisafa will one of you be able to double check this and then merge it? We would like these changes merged into master soon so we can update the cloudlab profile.

WilliamMaa commented 3 years ago

I think it is better that we do not include making dpdk in the root Makefile, I think dpdk's build is a little complicated than I imagined.

kevindweb commented 3 years ago

@onvm sanity

onvm commented 3 years ago

@onvm sanity

CI Message

Your results will arrive shortly

twood02 commented 3 years ago

@dennisafa when you have a chance, please sync this to master too (you don't need to make a full release).