Closed WilliamMaa closed 3 years ago
In response to PR creation
Aborting, need an authorized user to run CI
These changes look good to me. @kevindweb or @dennisafa will one of you be able to double check this and then merge it? We would like these changes merged into master soon so we can update the cloudlab profile.
I think it is better that we do not include making dpdk in the root Makefile, I think dpdk's build is a little complicated than I imagined.
@onvm sanity
@onvm sanity
Your results will arrive shortly
@dennisafa when you have a chance, please sync this to master too (you don't need to make a full release).
This PR relates to issue #262. I fixed some documentation issues, and improved general usability of onvm.
Summary:
Merging notes:
TODO before merging :
Test Plan:
Try doing a make in a Ubuntu 20 environment under the root directory, see if it can correctly make everything. On cloudlab profiles, run setup_cloudlab.sh see if it correctly does the setup.
Review:
(optional) << @-mention people who should review these changes >>
(optional) Subscribers: << @-mention people who probably care about these changes >>