sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
261 stars 134 forks source link

Skeleton NF Functionality Improvements #313

Closed jettjacobs closed 1 year ago

jettjacobs commented 2 years ago

Summary:

Changes Resolved From #312

Additional Functionality:

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality X
New NF/onvm_mgr args
Changes to starting NFs X
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

Review:

Review comments to confirm validity Command-line arguments should be mutually exclusive

dennisafa commented 2 years ago

Did you want to close this PR and make your updates as a new commit to your previous PR? Otherwise, could you close the other PR out?

jettjacobs commented 2 years ago

@dennisafa I will close out the other PR, thanks! I created a new PR to pull from my own forked develop branch, rather than master.

jettjacobs commented 2 years ago

@dennisafa sorry about dismissing the review, I had to make one more adjustment. Merge conflicts are now resolved

twood02 commented 2 years ago

@catherinemeadows sometime when I am not around, could you do a meeting where you show the summer students how you would test and eventually approve this PR? That would be good for them to see.

catherinemeadows commented 2 years ago

@catherinemeadows sometime when I am not around, could you do a meeting where you show the summer students how you would test and eventually approve this PR? That would be good for them to see.

Yep, will do!