sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
261 stars 134 forks source link

ARP Endianness Fixed #317

Closed NoahChinitz closed 2 years ago

NoahChinitz commented 2 years ago

The byte ordering of the ARP Response NF was correctly getting MAC address, but would get the IP address backwards. With a quick one line fix using rte_cpu_to_be_32 the MAC address and IP address are both correct.

Before: image As you can see the IP address reported by the ARP response is 1.1.10.10, when in fact the correct IP is 10.10.1.1. image We can see here that the HWAddress of onvm-link-0 is incomplete.

After: image We can see that ARP was giving a response and finding it at onvm-link-0. image image I was able to verify that onvm-link-0 is the correct hostname from arp -v as well as using arping

Summary:

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes X
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

The change was tested using arping, tcpdump, arp -v, and route -n to ensure correct MAC and IP.

twood02 commented 2 years ago

@dennisafa you can merge this into develop and master

dennisafa commented 2 years ago

Merged into master as well via cherry-pick. @twood02