sdnfv / openNetVM

A high performance container-based NFV platform from GW and UCR.
http://sdnfv.github.io/onvm/
Other
261 stars 134 forks source link

Scaling Example NF Updates #321

Closed catherinemeadows closed 2 years ago

catherinemeadows commented 2 years ago

Modified the Scaling Example NF to assign spawned children with the same service ID as the parent and updated the README with more detail about callback and advanced rings modes.

Summary:

Usage:

This PR includes
Resolves issues 250
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

TODO before merging :

Test Plan:

twood02 commented 2 years ago

@catherinemeadows Can you remind me -- Is the idea of this NF that it spawns N child NFs all with the same service ID as the "main" NF that started initially. Packets are then distributed across the N+1 NFs. All of these NFs then forward packets to whatever destination ID was set on the command line.

Is this right? Or does the main NF not actually have a run loop so there are N nfs total receiving packets (only the children)?

catherinemeadows commented 2 years ago

@twood02 Yes, the parent NF spawns N children NFs with the same service ID and the packets are distributed across the N+1 NFs and forwarded to the destination ID. Should I add this to the documentation?

twood02 commented 2 years ago

@NoahChinitzGWU can you build and run this code on one of your systems to verify it is working as expected? Post a screenshot/paste the output here

NoahChinitz commented 2 years ago

Manager: Screenshot from 2022-03-21 17-32-06

Scaling NF Left Terminal, Monitor NF Right Terminal: Screenshot from 2022-03-21 17-32-30

Does this seem correct, or should I be seeing 3 additional scaling NFs in the manager?

catherinemeadows commented 2 years ago

They should scale once you send packets to it (you can use speed tester)

NoahChinitz commented 2 years ago

Manager: Screenshot from 2022-03-21 17-44-17

Works!

NoahChinitz commented 2 years ago

Screenshot from 2022-03-21 17-45-01

NFs used (scaling left, basic monitor middle, speed tester right)

twood02 commented 2 years ago

@dennisafa - can you do a very quick review and approve this if nothing jumps out at you?