sdouglass / spring-social-tumblr

Spring Social client implementation for Tumblr
Apache License 2.0
17 stars 12 forks source link

Replace log4j and commons-logging with slf4j #13

Closed jramsdale closed 11 years ago

jramsdale commented 11 years ago

commons-logging has known classloading problems and not every downstream user wants to use log4j. Better to use slf4j for logging abstraction and let the user decide where to log.

sdouglass commented 11 years ago

Turns out I don't actually use Log4J anywhere, so I think I'm just going to remove that dependency. I think I'd actually prefer not to specify any logging dependencies at all if I can avoid it. I'd rather not take any side in the whole logging situation.

jramsdale commented 11 years ago

Even better.

-j

On Tue, Jun 18, 2013 at 5:16 PM, Sam Douglass notifications@github.comwrote:

Turns out I don't actually use Log4J anywhere, so I think I'm just going to remove that dependency. I think I'd actually prefer not to specify any logging dependencies at all if I can avoid it. I'd rather not take any side in the whole logging situation.

— Reply to this email directly or view it on GitHubhttps://github.com/sdouglass/spring-social-tumblr/pull/13#issuecomment-19652222 .