search

sdouglass / spring-social-tumblr

Spring Social client implementation for Tumblr
Apache License 2.0
17 stars 12 forks source link

Support Non ASCII posts #15

Open splix opened 10 years ago

splix commented 10 years ago

Currently it supports only US-ASCII symbols (because of TumblrSigningSupport:288). As I see, it's limited to this symbos on purpose, but not sure why it required. Official Jumblr client doesn't have such limitation.

I tried both clients, using non ascii input: spring-social-tumblr puts ???? ?? 04.04.2014 instead of Курс на 04.04.2014. Both for body and title. Jumblr posts correct characters, on both cases, so it's definitly possible and supported by Tumblr API.

sdouglass commented 10 years ago

At the time that I put in that hard coded usage of US-ASCII I did it as part of trying to get file posts to work (photos, audio, photo sets, etc.). At that point Tumblr's API didn't support multipart form posts, and required some non-standard encoding usage in the OAuth code. It does look like they support multipart form posts now, judging from the Jumblr code. I will see if I can get Spring Social Tumblr to handle file posts via multipart now, the way Jumblr does it, at which point I could probably get rid of the hard coded US-ASCII and just revert to using Spring Social's SigningSupport class.

sdouglass commented 10 years ago

Here is a thread where I tried to get help from Tumblr and other people using their API to figure out file posts:

https://groups.google.com/d/msg/tumblr-api/IDI4QFNMAE4/RsePzeUq9GAJ

I even tried to file a bug about it, but never got a response:

https://getsatisfaction.com/tumblr/topics/tumblr_v2_api_issues_when_posting_binary_data_e_g_photos

splix commented 10 years ago

Oh, I see. But looks like Tumblr has fixed this on their side. At least Jumblr client works for me, I'm able to create non-ascii text posts