search

sdr-enthusiasts / docker-adsb-ultrafeeder

ADSB-Ultrafeeder is an all-in-one ADSB container with readsb, tar1090, graphs1090, autogain, multi-feeder, and mlat-hub built in
GNU General Public License v3.0
180 stars 32 forks source link

Use pipe fail, quote array expansion and prevent word globbing #96

Closed fredclausen closed 4 months ago

fredclausen commented 4 months ago

The previous PRs failed to build because hadolint was mad. I think this fixes the problem but I'm curious about unintended side affects.

fredclausen commented 4 months ago

@wiedehopf

wiedehopf commented 4 months ago

Hmmm it would seems the PRs don't run the build automatically otherwise i would have seen this i think?

The changes in this PR seem fine to me.

fredclausen commented 4 months ago

We are wildly inconsistent with requiring hadolint/other linters before building/merging, as well as the kinds/types of builds we do on PRs.

I've added a pr flow to this PR and it's unhappy about something. I can't diagnose now, but I'll see what it doesn't like as soon as I can.

wiedehopf commented 4 months ago

This seems to be showing errors for the state before your last commit. Possibly because of when you requested the review?

Might need to re-request the review on the current state.

Anyhow your change looks good to me.

fredclausen commented 4 months ago

Yeah I think the error was the original commit + my commit with the PR build action. The fix in the last commit seems to have fixed it. I'll do a local test build soon to make sure the build isn't broken before I merge in, but when I build it on my laptop it looks like it's doing everything right.

wiedehopf commented 4 months ago

local build of this branch works fine.

mlat-client starts up ... all seems good :)

fredclausen commented 4 months ago

I'll merge it then :) Thanks @wiedehopf