search

sdr-enthusiasts / docker-planefence

GNU General Public License v3.0
91 stars 17 forks source link

change function of $ and # in headers #92

Open Sportsbadger opened 3 years ago

Sportsbadger commented 3 years ago

It seems logical to have # control tweeting behaviour and $ to control rendering behaviour. The current implementation is counter-intuitive.

kx1t commented 3 years ago

The history behind the current implementation is that # means "comment" in most programming languages. When we added the hashtag functionality, we needed a different character to distinguish. Another consideration is that changing this creates an impact on already fielded instances of Planefence and Plane-Alert. My goal is to provide as much backward compatibility as possible, with existing set-ups working perfectly fine even when new features come on-line.

Therefore I'd like to think this one through a bit longer - I definitely agree that "#" for hashtags is the most logical choice, but I want to consider the impact of making this change before committing.

On Mon, Jun 7, 2021 at 8:28 AM Sportsbadger @.***> wrote:

It seems logical to have # control tweeting behaviour and $ to control rendering behaviour. The current implementation is counter-intuitive.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kx1t/docker-planefence/issues/92, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTEHUZQVHKQB3UNACXENATTRS3PZANCNFSM46HR47PQ .