sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, πŸ¦‰ LIGHT OWL: a daytime light theme
https://aka.ms/nightowl
MIT License
2.82k stars 243 forks source link

Override comment colour #197

Closed ronny closed 5 years ago

ronny commented 5 years ago

Describe the solution you'd like

I'd like to be able to override comment foreground colour by doing something like this in my user settings:

"editor.tokenColorCustomizations": {
  "comments": {
    "foreground": "#FFFFFF",
  }
}

or

"editor.tokenColorCustomizations": {
  "[Night Owl]": {
    "comments": {
      "foreground": "#FFFFFF",
    }
  }
}

Is your feature request related to a problem? Please describe.

The above override doesn't work for Night Owl, while it works for other themes. I have tried this with double slash comments and /* .. */ style comments, for Go specifically.

Thank you!

sdras commented 5 years ago

Try this and let me know if it worked:

"editor.tokenColorCustomizations": {
  "[Night Owl]": {
    "comments": {
      "foreground": "#FFFFFF",
    },
   "comment.line.double-slash": {
      "foreground": "#FFFFFF",
    }
  }
}
ronny commented 5 years ago

@sdras Thanks for the suggestion. I tried and it didn't work unfortunately. I also tried this which didn't work either:

"editor.tokenColorCustomizations": {
    "comments": {
      "foreground": "#FFFFFF",
    },
   "comment.line.double-slash": {
      "foreground": "#FFFFFF",
    }
}
sdras commented 5 years ago

Try this:

"workbench.colorCustomizations": {
    "comments": {
      "foreground": "#FFFFFF",
    },
   "comment.line.double-slash": {
      "foreground": "#FFFFFF",
    }
}
ronny commented 5 years ago

Didn't work either 😞 I think it may be an issue with VSCode itself. Thanks for the suggestions (and for the themes!), @sdras.

sdras commented 5 years ago

Ok! I'll close it out then, sorry it's not working. Let me know if you think there's something to be done.

ronny commented 5 years ago

I finally got this to work:

  "editor.tokenColorCustomizations": {
    "[Night Owl]": {
      "comments": {
        "foreground": "#ffffff"
      },
      "textMateRules": [
        {
          "scope": "comment.line.double-slash",
          "settings": {
            "foreground": "#ffffff"
          }
        }
      ]
    }
}
erantona commented 3 years ago

None of these work for meπŸ˜₯πŸ˜₯πŸ˜₯

Seungwan-Jung commented 3 years ago

Thanks Ronny! I was searching for the exact same issue!

arskhan741 commented 4 months ago

None of these work for meπŸ˜₯πŸ˜₯πŸ˜₯

The Last script posted by Ronny worked for me. Make sure your theme name is same. My theme name was "Night Owl (No Italics)" but the theme name in script is [Night Owl].