search

sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme
https://aka.ms/nightowl
MIT License
2.81k stars 243 forks source link

Suggestion: Add `menu.border` color #215

Open black-black-cat opened 5 years ago

black-black-cat commented 5 years ago

Thanks so much for this theme @sdras!

The menu border is not distinguished from the background color. Can you add menu.border color?

owl

12345

When I add menu.border in custom, I found the border-width is wider than I expected. Is this border-width acceptable?

2019

sdras commented 5 years ago

iirc that's why I didn't set it. I felt it was too bold and distracting. I'm ok with the menu border as-is, but we could add in the readme how to configure it if it bothers you (like I did with the sidebar, etc). Open to a PR for the README.

phiter commented 4 years ago

Hey @sdras I also had this issue with the menu not having a border, I think a very subtle border would look nice. Look at this:

image

I'm using

"workbench.colorCustomizations": {
    "[Night Owl (No Italics)]": {
        "menu.border": "#00000088"
    }
}