Refactor invalid token colors

sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme

https://aka.ms/nightowl

MIT License

2.82k stars 243 forks source link

Refactor invalid token colors #219

Closed jlmakes closed 4 years ago

jlmakes commented 5 years ago

Fixes #218

Compare with this screenshot, where align is both visible and styled appropriately.

Screen Shot 2019-07-09 at 12 09 31 PM

jlmakes commented 5 years ago

Note: This is just for the light theme since it was broken, but similar improvements could be made to the dark theme as well. All in good time! :)

sdras commented 5 years ago

align attribute is deprecated in HTML. Can you please post before/after screenshots of non-deprecated attributes? Thanks!

jlmakes commented 5 years ago

I only modified the invalid/deprecated scope, for the light theme.

Before: Before

After: After

As you can see, valid attributes are still blue… this only affects the deprecated attribute.

sdras commented 4 years ago

Can you please resolve the conflicts? Then I will merge. Thanks!

macguirerintoul commented 4 years ago

Hey @jlmakes, is this still open? I just ran into this issue myself.

jlmakes commented 4 years ago

I deleted the original fork. I'll apply the fix to the latest branch and open a new PR.