sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme
https://aka.ms/nightowl
MIT License
2.81k stars 243 forks source link

Fix *HighlightBackground transparency #238

Closed MarcelloNicoletti closed 4 years ago

MarcelloNicoletti commented 4 years ago

Fix description

There are a few editor.<something>HighlightBackground color settings. These colors are supposed to be semi-transparent to allow other decorations to show through.

I calculated new semi-transparent colors that blend with the theme background color into the original color value. I tried to get values that were 20% opaque. One of the values would've needed an impossible base color to blend correctly at 20% opaque so I had to calculate it at a higher opacity.

All translations

Examples

In these examples I've selected the letters pri in the first this.price. That first instance of this.price has editor.wordHighlightStrongBackground. The other two this.prices have editor.wordHighlightBackground. In the before images you can't tell that those letters are selected because the opaque color is rendered over the selection.

Dark

Before

Dark Theme Before

After

Dark Theme After

Light

Before

Light Theme Before

After

Light Theme After (note: The light theme's editor.wordHighlightStrongBackground was the color that had to be more opaque)

sdras commented 4 years ago

This looks great and is much more clear, much appreciated!