Command palette inconsistency

sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme

https://aka.ms/nightowl

MIT License

2.82k stars 243 forks source link

Closed napei closed 4 years ago

napei commented 4 years ago

The command palette has a different background color for Italics and No italics theme

Screenshots

demo

ivansvlv commented 4 years ago

@sdras hi 👋🏻 I apologize, I couldn't find a contribution guide for the project, so I've just created a PR for this: https://github.com/sdras/night-owl-vscode-theme/pull/271

It reconciles colour differences between themes in favour of italic one, since noitalic shouldn't change colours in the first place.

napei commented 4 years ago

Awesome. Thanks for the fix :)

ivansvlv commented 4 years ago

@napei i'm glad i could help 😉