2.0 isn't coloring/dinstinctint template literals from strings

sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme

https://aka.ms/nightowl

MIT License

2.82k stars 243 forks source link

2.0 isn't coloring/dinstinctint template literals from strings #274

Open JavierPiedra opened 4 years ago

JavierPiedra commented 4 years ago

sdras commented 4 years ago

well, hm... someone else asked that they be the same color. I have to think of what to do now. I think I agree with you, let me use the new version a bit and see.

ivansvlv commented 4 years ago

Do you think it's necessary or useful to colour them differently? Template literal produces a string so it's quite intuitive to consider it as a string. Besides, template literals usual usage is to interpolate values into the string, and I would argue that Night Owl has one of the best interpolation highlighting, thus making it pretty obvious what are you working with.

JavierPiedra commented 4 years ago

Do you think it's necessary or useful to colour them differently? Template literal produces a string so it's quite intuitive to consider it as a string. Besides, template literals usual usage is to interpolate values into the string, and I would argue that Night Owl has one of the best interpolation highlighting, thus making it pretty obvious what are you working with.

Yes, it has been useful to me, specially to find it quickly. I notice the change.

selensr commented 3 years ago

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Screen Shot 2020-11-25 at 10 19 42

ivansvlv commented 3 years ago

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Do you have this extension installed? - https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

If yes, it might be causing your component colouring change.

selensr commented 3 years ago

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Do you have this extension installed? - https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

If yes, it might be causing your component colouring change.

Yes, it is indeed. Thank you a lot. Tags and texts back to normal.