search

sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme
https://aka.ms/nightowl
MIT License
2.81k stars 243 forks source link

Coloring for Object properties defined by shorthand #275

Open abhijit-hota opened 3 years ago

abhijit-hota commented 3 years ago

Please make sure you're using the latest version of the plugin before submitting an issue Version: 2.0.0

Object properties that are defined using the shorthand (line 26 in the screenshot), should also have the purple color that is given for properties defined as usual.

Screenshots image

Not sure if this is intended or a bug but I think making all the keys of same color would be better.

P.S. Thanks for the awesome theme! =)

sdras commented 3 years ago

Thank you! I have to use it and think about it a minute, because someone else wanted this to be distinct. Appreciate the feedback!

ivansvlv commented 3 years ago

IMO, having this distinction in syntax highlighting emphasises shorthand, since colour of the shorthand matches the colour of the identifier that is used, it improves legibility.

Just my 2 cents.

abhijit-hota commented 3 years ago

colour of the shorthand matches the colour of the identifier that is used

But aren't all identifiers colored white after initialization? I might be wrong here.

Although, they're fair points and looking at it, a distinction between the shorthand is good when it resembles the type of variable (but that doesn't seem to the case?).