sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme
https://aka.ms/nightowl
MIT License
2.81k stars 242 forks source link

Night Owl theme is either overriding or not specifying default markup textMateRules #57 #105 #283

Open smcenlly opened 3 years ago

smcenlly commented 3 years ago

Describe the bug Theme is either overriding or not specifying default markup textMateRules that are provided with VS Code default themes. This breaks syntax highlighting in extensions that use these rules.

To Reproduce Steps to reproduce the behavior:

  1. Clone https://github.com/smcenlly/missing-textmate-tokens VS Code sample extension.
  2. Open the repo and run npm install
  3. Open the repo in VS Code and Start debugging (F5).
  4. Create a new file (Ctrl + N).
  5. Change its language to markup using the Change Language Mode command
  6. Paste the contents below:
deleted

inserted

underline
  1. Using any of the VS Code themes, you will see output similar to: Working Example

Expected behavior Theme should provide similar formatting (adjusted to its themes). Instead, no highlighting is displayed.

image

smcenlly commented 3 years ago

Bumping this issue - any plans to fix?