sdras / night-owl-vscode-theme

🌌 NIGHT OWL: A VS Code dark theme for contrast for nighttime coding, 🦉 LIGHT OWL: a daytime light theme
https://aka.ms/nightowl
MIT License
2.82k stars 243 forks source link

Preview images are not showing in VS code extension preview, though it is showing on github's readme #284

Closed DashmeetArt closed 3 years ago

DashmeetArt commented 3 years ago

image

I found that the image url which is present over there is not accessible. https://github.com/sdras/night-owl-vscode-theme/raw/master/first-screen.jpg https://github.com/sdras/night-owl-vscode-theme/raw/master/three-dark.jpg https://github.com/sdras/night-owl-vscode-theme/raw/master/light-owl-full.jpg https://github.com/sdras/night-owl-vscode-theme/raw/master/three-light.jpg

Thanks!

dzhavat commented 3 years ago

This happened with some of my extensions as well. The reason is because the default branch had been renamed from master to main.

The way to fix this is by using --githubBranch flag when publishing a new version of the extension. This is also described in the docs.

sdras commented 3 years ago

Fixed! Thank you for filing.