Fixing some TODOs and Iterator refactor

sdroege / ebur128

Implementation of the EBU R128 loudness standard

MIT License

93 stars 15 forks source link

Fixing some TODOs and Iterator refactor #45

Closed zotho closed 3 years ago

sdroege commented 3 years ago

Looks good to me otherwise, thanks a lot for the cleanup!

sdroege commented 3 years ago

I commented on the individual commits btw

sdroege commented 3 years ago

Can you get rid of the Revert iterator refactor / Iterator refactor commits by rebasing? They don't give anything useful in the commit history :)

zotho commented 3 years ago

@sdroege Got rid of Iterator refactor, Revert iterator refactor, Use assert_eq instead assert, unwrap_or_default fix commits. Should look cleaner.

sdroege commented 3 years ago

Thanks!