sdroege / rtsp-types

RTSP (RFC 7826) types and parsers/serializers
MIT License
26 stars 13 forks source link

Added serde derived Serializer behind a feature flag #28

Closed josephhajduk closed 1 month ago

josephhajduk commented 1 month ago

Did not add it to builders or error types.

This was useful for me, thanks for the very useful library. I made a similar PR to sdp-types

josephhajduk commented 1 month ago

I didn't need Deserialize but it is easy enough to add it, I am using it for tracing/logging.

sdroege commented 1 month ago

I see, that makes sense

sdroege commented 1 month ago
  namespaced features with the `dep:` prefix are only allowed on the nightly channel and requires the `-Z namespaced-features` flag on the command-line

That's OK, let's update the MSRV to something more reasonable that supports this :) I'll do that, don't worry about it.

josephhajduk commented 1 month ago

Great thanks!

sdroege commented 1 month ago

Did not add it to builders or error types.

OOC, why did you add it to error types in sdp-types but not here?

josephhajduk commented 1 month ago

I was wildly pasting in sdp-types and didn't think it through, I don't think it makes sense either I will remove it