search

sdroege / rtsp-types

RTSP (RFC 7826) types and parsers/serializers
MIT License
26 stars 13 forks source link

Qian #8

Closed qianzhang5 closed 3 years ago

qianzhang5 commented 3 years ago

Done.

On Sun, May 9, 2021 at 1:28 AM Sebastian Dröge @.***> wrote:

@.**** commented on this pull request.

Looks good to me otherwise, thanks!

Please squash that documentation fixup into the corresponding commit instead of adding a new commit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sdroege/rtsp-types/pull/8#pullrequestreview-655054013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCC3ABQRCOCHZTE6YLD2E3TMZBTHANCNFSM44OPR36Q .

qianzhang5 commented 3 years ago

Done.

On Sun, May 9, 2021 at 11:48 PM Sebastian Dröge @.***> wrote:

@.**** commented on this pull request.

In src/message.rs https://github.com/sdroege/rtsp-types/pull/8#discussion_r629087175:

@@ -159,6 +159,10 @@ pub enum Method { Setup, /// Set parameter SetParameter,

  • /// Announce (only RTSP 1.0)
  • Announce,
  • /// Record
  • Record,

Looks good otherwise, thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sdroege/rtsp-types/pull/8#discussion_r629087175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCC3ACCEEJBBKX6JC5P5V3TM56VDANCNFSM44OPR36Q .

sdroege commented 3 years ago

Thanks again!