sds / overcommit

A fully configurable and extendable Git hook manager

MIT License

3.92k stars 280 forks source link

Where do these YamlSyntax errors come from? #642

Closed veganstraightedge closed 5 years ago

veganstraightedge commented 5 years ago

My .overcommit .yml

PreCommit:
  YamlSyntax:
    enabled: true

Errors in output

When I run overcommit -r

Running pre-commit hooks
sh: -c: line 0: unexpected EOF while looking for matching `"'
sh: -c: line 1: syntax error: unexpected end of file
Check YAML syntax........................................[YamlSyntax] OK

✓ All pre-commit hooks passed

This is for https://github.com/crimethinc/website/

Thanks! I really appreciate y'all making and maintaining Overcommit! 🎉

sds commented 5 years ago

Thanks for the report, @veganstraightedge.

This actually had nothing to do with the YamlSyntax hook. Fixed in 7e8e6f21ab10a579beb9f9c49478040ef10d8e22.

veganstraightedge commented 5 years ago

Great! Thanks @sds. What's the process/timeline for that change landing in the homebrew recipe?

sds commented 5 years ago

This project doesn't maintain a Homebrew formula, so I would ask the formula maintainer.

veganstraightedge commented 5 years ago

Thanks

veganstraightedge commented 5 years ago

Sorry. I was moving too fast and not thinking through what I actually meant.

What I should've asked was, what's the process/timeline to release a new patch version of the overcommit gem?

sds commented 5 years ago

We don't have any clear schedules published at this time.

0.48.1 has been released.

veganstraightedge commented 5 years ago

Righteous! Thanks again.

/end