search

sds / overcommit

A fully configurable and extendable Git hook manager
MIT License
3.91k stars 280 forks source link

Partial log flushing to make long hooks intuitive #777

Closed rickmark closed 2 years ago

rickmark commented 2 years ago

Today a long hook will not print any output until it is complete.

This change introduces flushing (when available) to the status lines so that a hook will output before its run

sds commented 2 years ago

RSpec 3 failure looks spurious.

rickmark commented 2 years ago

RSpec 3 failure looks spurious.

Which part? My machine uses main for initial branch - which blew up the tests I also got errors on Bundler thus adding the require Is there a failure I didn't catch?

sds commented 2 years ago

See the failed Ruby 3.0 Windows build. No action required from you—was merely commenting that we are merging in spite of what appears to be a spurious failure.

rickmark commented 2 years ago

Ah - yeah - I admit - I didn't bother with a windows test run - would you like a patch-set to do CI on PRs? (We do this in https://github.com/hack-different/apple-knowledge/blob/main/.github/workflows/jekyll_ci.yml to run Jekyll but it could easily run spec)?

rickmark commented 2 years ago

OM... just realized its a closed PR so I wasn't seeing the checks - carry on