sds / overcommit

A fully configurable and extendable Git hook manager
MIT License
3.92k stars 280 forks source link

Overcommit doesn't work with Stylelint 16 #823

Closed mattbrictson closed 5 months ago

mattbrictson commented 8 months ago

Stylelint 16 made a breaking change: lint failures are now printed on stderr instead of stdout.

Overcommit hasn't yet been updated to support Stylelint 16, and still expects the output on stdout. As a result, the pre-commit hook prints "OK" when there are actual lint failures.

Stylelint documentation regarding the breaking change: https://stylelint.io/migration-guide/to-16#breaking-changes

I suspect the best way to solve this is for Overcommit to check both stderr and stdout, so that new and old versions of Stylelint are supported.