search

sdsc-ordes / gimie

Extract linked metadata from repositories
https://sdsc-ordes.github.io/gimie/
Apache License 2.0
6 stars 2 forks source link

Licenses not being picked up correctly #65

Closed rmfranken closed 1 year ago

rmfranken commented 1 year ago

gimie data 'https://github.com/facebookresearch/co-tracker' --format 'json-ld' returns, among other triples: "http://schema.org/license": [ { "@id": "https://spdx.org/licenses/NOASSERTION" } I'm not aware of such a license, nor is spdx. In any case, if it believes there is no license, I would not expect a triple at all... Maybe we can put in an exception? Right now there is a if data["licenseInfo"] is not None: But I guess that doesn't help if gitHub returns some sort of "NOASSERTION". Not sure why our license grabber is having a hard time with this one, the license.md file clearly states: Attribution-NonCommercial 4.0 International at the top of page :confused:

rmfranken commented 1 year ago

Will try to program an exception around this:

Preferably: If NOASSERTION -> Return some kind of "catch all" license if that exists.

Otherwise, NOASSERTION should = None, so that no triple is returned in the case that no license was matched.

rmfranken commented 1 year ago

https://github.com/SDSC-ORD/gimie/pull/66