sdss / autoscheduler

The SDSS scheduler
1 stars 2 forks source link

Replace astropysics? #2

Open albireox opened 4 years ago

albireox commented 4 years ago

Both the autoscheduler and Petunia use atropysics, which is not maintained anymore and that is becoming increasingly complicated to install. Maybe consider replacing it with astropy?

johndonor3 commented 4 years ago

There are basically 2 things we use this for: getting alt/az and converting to/from LST. The equivalent logic for alt/az is in the astropy affiliated astroplan package. Based on experience with observesim I suspect it might be significantly slower though. The equivalent LST logic is in Totoro I guess?

In theory this would probably take a few hours to update and test. But I would lean towards "it should be fine for the last few months of the survey"?

albireox commented 4 years ago

That's reasonable. Maybe you can just document how to install astropysics these days since each time I have to do it it takes me 10 minutes to figure it out. It involves cloning the repo (not installing from pip), then modifying DEFAULT_URL in distribute_setup.py by changing http with https.

Totoro uses astropy. In a couple places (the LST among others, I think) it actually does the calculation instead of calling astropy. As you say astropy used to be slow but I think that's mostly fixed, at least for small number of coordinates.