search

sdss / lvmdrp

Local Volume Mapper (LVM) Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Adds new header keys to drpall #115

Closed havok2063 closed 1 month ago

havok2063 commented 1 month ago

This PR closes #111 and adds the OBJECT and OBSTIME header keys to the drpall file. It also adds new tests.

This also pins numpy < 2.0 for now due to some issues with pandas, when writing out to hdf5 file. You may see an error ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject. See, e.g. https://github.com/numpy/numpy/issues/26710 or https://stackoverflow.com/questions/78634235/numpy-dtype-size-changed-may-indicate-binary-incompatibility-expected-96-from Will create a new issue to keep this on our radar.

havok2063 commented 1 month ago

@ajmejia when you get a chance, can you comment on this? In particular are you ok with me pinning numpy < 2 until further testing can be done.

ajmejia commented 1 month ago

@ajmejia when you get a chance, can you comment on this? In particular are you ok with me pinning numpy < 2 until further testing can be done.

Go ahead! Neither of us has the bandwidth to properly test/debug compatibility issues in dependencies, specially in the case of a core dependency such as Numpy.