search

sdss / lvmdrp

Local Volume Mapper (LVM) Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Skydev issues110 77 #137

Open ymamay opened 1 month ago

ymamay commented 1 month ago

PR to merge skydev_issues110_77 into main. I updated and re-organized the sky header keywords and comments. Still needs more testing and there are four more skymodel header keywords that need to be added (see comments in skymodel_pars_header to add moon ra, moon dec, moon phase, and moon illumination). Also should update how the drpall grabs these keywords (note the shadow_height keywords are now sh_hght, and several of the {telescope} is removed). Closes #110.

ymamay commented 1 month ago

Oh also I tried to format the header values so they would have a limited number of decimal points. In doing so I think the values are now strings, not sure if this is important for future functions (like building the drpall file)

ymamay commented 4 days ago

@ajmejia @havok2063 I think this is ready to be merged now. Ran on a subset of the refdata and the drpall file looked ok

havok2063 commented 4 days ago

Some of the CI isn't passing. See the failing checks. Can you merge the latest master into this branch? This should clear up some of them. It looks like there may be other linting issues that need to be resolved.

havok2063 commented 3 days ago

Looks good to me!