sdss / lvmdrp

Local Volume Mapper (LVM) Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Adds method for combining spectrographs into single new #8

Closed havok2063 closed 1 year ago

havok2063 commented 1 year ago

This PR adds a new function and pipeline step for combining the spectographs into a single file. This combines the camera-combined ancillrary lvm-object-sp[x]-[expnum].fits files (3 files), for a given exposure, into the output lvm-CFrame-[expnum].fits file which will be input into the sky subtraction module. The data are stacked as [sp1, sp2, sp3] which makes the data ordered "bottom-to-top", i.e. the 0-index array element is the start of sp1 fibers.

The extensions of the file are:

ajmejia commented 1 year ago

I'm getting an No entry lvm_frame found error. Please update requirements.txt with the current version of sdss-tree so that I can keep testing this branch.

havok2063 commented 1 year ago

I haven't tagged a new release of tree yet. If you want to test it, you should install the dev version of the sdss-tree product from github, and checkout the lvmup branch. In your conda environment, you can just do pip install -e . to install the repo tree.

havok2063 commented 1 year ago

Just to clarify, I don't think we need to change the requirements.txt file. It should always point to a tagged release. Working off the latest version is only for development and testing purposes.